[DevTools] Simplify Popover API

third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 38 matching lines @@
 
     this._overviewGrid.setResizeEnabled(false);
     this._overviewGrid.addEventListener(PerfUI.OverviewGrid.Events.WindowChanged, this._onWindowChanged, this);
     this._overviewGrid.setClickHandler(this._onClick.bind(this));
     this._overviewControls = [];
     this._markers = new Map();
 
     this._popoverHelper = new UI.PopoverHelper(this._cursorArea);
     this._popoverHelper.initializeCallbacks(
         this._getPopoverAnchor.bind(this), this._showPopover.bind(this), this._onHidePopover.bind(this));
+    this._popoverHelper.setHasPadding(true);
     this._popoverHelper.setTimeout(0);
 
     this._updateThrottler = new Common.Throttler(100);
 
     this._cursorEnabled = false;
     this._cursorPosition = 0;
     this._lastWidth = 0;
   }
 
   /**
    * @param {!Element} element
    * @param {!Event} event
    * @return {!Element|!AnchorBox|undefined}
    */
   _getPopoverAnchor(element, event) {
     return this._cursorArea;
   }
 
   /**
    * @param {!Element} anchor
-   * @param {!UI.Popover} popover
+   * @param {!UI.GlassPane} popover
+   * @return {!Promise<boolean>}
    */
   _showPopover(anchor, popover) {
-    this._buildPopoverContents().then(maybeShowPopover.bind(this));
+    return this._buildPopoverContents().then(maybeShowPopover.bind(this));
+
     /**
      * @this {PerfUI.TimelineOverviewPane}
      * @param {!DocumentFragment} fragment
+     * @return {boolean}
      */
     function maybeShowPopover(fragment) {
       if (!fragment.firstChild)
-        return;
+        return false;
       var content = new PerfUI.TimelineOverviewPane.PopoverContents();
       this._popoverContents = content.contentElement.createChild('div');
       this._popoverContents.appendChild(fragment);
       this._popover = popover;
-      popover.showView(content, this._cursorElement);
+      content.show(popover.contentElement);
+      return true;
     }
   }
 
   _onHidePopover() {
     this._popover = null;
     this._popoverContents = null;
   }
 
   /**
    * @param {!Event} event
@@ skipping 434 matching lines @@
    */
   onClick(event) {
     return false;
   }
 
   resetCanvas() {
     this._canvas.width = this.element.clientWidth * window.devicePixelRatio;
     this._canvas.height = this.element.clientHeight * window.devicePixelRatio;
   }
 };