[DevTools] Simplify Popover API

third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 59 matching lines @@
     this._selectEnabled = selectEnabled;
     /** @type {?SDK.DOMNode} */
     this._rootDOMNode = null;
     /** @type {?SDK.DOMNode} */
     this._selectedDOMNode = null;
 
     this._visible = false;
 
     this._popoverHelper = new UI.PopoverHelper(this._element);
     this._popoverHelper.initializeCallbacks(this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
+    this._popoverHelper.setHasPadding(true);
     this._popoverHelper.setTimeout(0, 100);
 
     /** @type {!Map<!SDK.DOMNode, !Elements.ElementsTreeOutline.UpdateRecord>} */
     this._updateRecords = new Map();
     /** @type {!Set<!Elements.ElementsTreeElement>} */
     this._treeElementsBeingUpdated = new Set();
 
     this._domModel.addEventListener(SDK.DOMModel.Events.MarkersChanged, this._markersChanged, this);
     this._showHTMLCommentsSetting = Common.moduleSetting('showHTMLComments');
     this._showHTMLCommentsSetting.addChangeListener(this._onShowHTMLCommentsChange.bind(this));
@@ skipping 475 matching lines @@
           naturalWidth: this.naturalWidth,
           naturalHeight: this.naturalHeight,
           currentSrc: this.currentSrc
         };
       }
     }
   }
 
   /**
    * @param {!Element} link
-   * @param {!UI.Popover} popover
+   * @param {!UI.GlassPane} popover
+   * @return {!Promise<boolean>}
    */
   _showPopover(link, popover) {
+    var fulfill;
+    var promise = new Promise(x => fulfill = x);
     var listItem = link.enclosingNodeOrSelfWithNodeName('li');
     var node = /** @type {!Elements.ElementsTreeElement} */ (listItem.treeElement).node();
     this._loadDimensionsForNode(
         node, Components.DOMPresentationUtils.buildImagePreviewContents.bind(
                   Components.DOMPresentationUtils, node.target(), link[Elements.ElementsTreeElement.HrefSymbol], true,
                   showPopover));
+    return promise;
 
     /**
      * @param {!Element=} contents
      */
     function showPopover(contents) {
-      if (!contents)
-        return;
-      popover.showForAnchor(contents, link);
+      if (contents)
+        popover.contentElement.appendChild(contents);
+      fulfill(!!contents);
     }
   }
 
   _onmousedown(event) {
     var element = this._treeElementFromEvent(event);
 
     if (!element || element.isEventWithinDisclosureTriangle(event))
       return;
 
     element.select();
@@ skipping 1086 matching lines @@
      */
     function resolved(node) {
       if (node) {
         this.treeOutline._selectedDOMNode = node;
         this.treeOutline._selectedNodeChanged();
       }
     }
     return true;
   }
 };