[DevTools] Simplify Popover API

third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 563 matching lines @@
    */
   _getPopoverAnchor(element, event) {
     var link = element;
     while (link && !link[Elements.ElementsTreeElement.HrefSymbol])
       link = link.parentElementOrShadowHost();
     return link ? link : undefined;
   }
 
   /**
    * @param {!Element} link
-   * @param {!UI.Popover} popover
+   * @param {!UI.GlassPane} popover
+   * @return {!Promise<boolean>}
    */
   _showPopover(link, popover) {
     var node = this.selectedDOMNode();
-    if (node) {
-      Components.DOMPresentationUtils.buildImagePreviewContents(
-          node.target(), link[Elements.ElementsTreeElement.HrefSymbol], true, showPopover);
-    }
+    if (!node)
+      return Promise.resolve(false);
+
+    var fulfill;
+    var promise = new Promise(x => fulfill = x);
+    Components.DOMPresentationUtils.buildImagePreviewContents(
+        node.target(), link[Elements.ElementsTreeElement.HrefSymbol], true, showPopover);
+    return promise;
 
     /**
      * @param {!Element=} contents
      */
     function showPopover(contents) {
-      if (!contents)
-        return;
-      popover.showForAnchor(contents, link);
+      if (contents)
+        popover.contentElement.appendChild(contents);
+      fulfill(!!contents);
     }
   }
 
   _jumpToSearchResult(index) {
     this._currentSearchResultIndex = (index + this._searchResults.length) % this._searchResults.length;
     this._highlightCurrentSearchResult();
   }
 
   /**
    * @override
@@ skipping 286 matching lines @@
         showMetrics.call(this, true);
       else if (tabId === Common.UIString('Styles'))
         showMetrics.call(this, false);
     }
 
     this.sidebarPaneView = UI.viewManager.createTabbedLocation(() => UI.viewManager.showView('elements'));
     var tabbedPane = this.sidebarPaneView.tabbedPane();
     if (this._popoverHelper)
       this._popoverHelper.hidePopover();
     this._popoverHelper = new UI.PopoverHelper(tabbedPane.element);
+    this._popoverHelper.setHasPadding(true);
     this._popoverHelper.initializeCallbacks(this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
     this._popoverHelper.setTimeout(0);
 
     if (horizontally) {
       // Styles and computed are merged into a single tab.
       this._splitWidget.installResizer(tabbedPane.headerElement());
 
       var stylesView = new UI.SimpleView(Common.UIString('Styles'));
       stylesView.element.classList.add('flex-auto');
 
@@ skipping 190 matching lines @@
    * @param {!SDK.DOMNode} node
    * @return {?{title: string, color: string}}
    */
   decorate(node) {
     return {
       color: 'orange',
       title: Common.UIString('Element state: %s', ':' + SDK.CSSModel.fromNode(node).pseudoState(node).join(', :'))
     };
   }
 };