content/browser/browser_plugin/browser_plugin_guest.cc - Issue 27408004: <webview>: Resolve relative paths as chrome-extension: URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 27408004: <webview>: Resolve relative paths as chrome-extension: URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed creis's comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_plugin/browser_plugin_guest.h ('K') | « content/browser/browser_plugin/browser_plugin_guest.h ('k') | content/public/browser/browser_plugin_guest_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index b8f7e24a2108263dbfb76888250361d4554783e8..5cb17edb515e4d132216bb682b39d15abcd5d79a 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -1339,7 +1339,7 @@ void BrowserPluginGuest::OnLockMouseAck(int instance_id, bool succeeded) {

void BrowserPluginGuest::OnNavigateGuest(

int instance_id,

const std::string& src) {

- GURL url(src);

+ GURL url = delegate_ ? delegate_->ResolveURL(src) : GURL(src);

// We do not load empty urls in web_contents.

// If a guest sets empty src attribute after it has navigated to some

// non-empty page, the action is considered no-op. This empty src navigation