Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4089)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 27408004: <webview>: Resolve relative paths as chrome-extension: URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed creis's comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index e4347f8edd524a8b1ac01c4988b837de54b0225c..d8b60c437521de9973a4186126e8e7c719e18f6f 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -842,7 +842,9 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(
// Create a new GuestView of the same type as the opener.
*guest_delegate =
- GuestView::Create(guest_web_contents, guest->GetViewType());
+ GuestView::Create(guest_web_contents,
+ guest->extension_id(),
+ guest->GetViewType());
return;
}
@@ -853,8 +855,12 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(
std::string api_type;
extra_params->GetString(guestview::kParameterApi, &api_type);
+ if (api_type.empty())
+ return;
+
*guest_delegate =
GuestView::Create(guest_web_contents,
+ std::string() /* extension_id */,
GuestView::GetViewTypeFromString(api_type));
}

Powered by Google App Engine
This is Rietveld 408576698