content/browser/browser_plugin/browser_plugin_guest_manager.cc - Issue 27408004: <webview>: Resolve relative paths as chrome-extension: URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest_manager.cc

Issue 27408004: <webview>: Resolve relative paths as chrome-extension: URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't update src attribute with resolved URL. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_plugin/browser_plugin_guest.cc ('K') | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/public/browser/browser_plugin_guest_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest_manager.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest_manager.cc b/content/browser/browser_plugin/browser_plugin_guest_manager.cc

index 35fe1fb1de42dab102e6c30be971bb0177eb6d7f..388aea00799637a0cb96f0b8a6bb684fb209fb9e 100644

--- a/content/browser/browser_plugin/browser_plugin_guest_manager.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest_manager.cc

@@ -75,8 +75,8 @@ BrowserPluginGuest* BrowserPluginGuestManager::CreateGuest(

} else {

// Only trust |embedder_frame_url| reported by a WebUI renderer.

const GURL& embedder_site_url = embedder_site_instance->GetSiteURL();

- GURL validated_frame_url(params.embedder_frame_url);

- RenderViewHost::FilterURL(

+ GURL validated_frame_url(params.embedder_frame_url);

+ RenderViewHost::FilterURL(

embedder_process_host, false, &validated_frame_url);

const std::string& host = content::HasWebUIScheme(embedder_site_url) ?

validated_frame_url.host() : embedder_site_url.host();