chrome/renderer/resources/extensions/web_view.js - Issue 27408004: <webview>: Resolve relative paths as chrome-extension: URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 27408004: <webview>: Resolve relative paths as chrome-extension: URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't update src attribute with resolved URL. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guestview/webview/webview_guest.cc ('K') | « chrome/renderer/extensions/document_custom_bindings.cc ('k') | chrome/test/data/extensions/platform_apps/web_view/shim/main.js » ('j') | chrome/test/data/extensions/platform_apps/web_view/shim/main.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/web_view.js

diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js

index 4ddfc10897143b8b4e46795119d576d94b62fb0b..9aa691035a5e8c1025c7994ba8cf4037766bd35d 100644

--- a/chrome/renderer/resources/extensions/web_view.js

+++ b/chrome/renderer/resources/extensions/web_view.js

@@ -646,7 +646,7 @@ WebViewInternal.prototype.handleLoadCommitEvent_ =

this.processId_ = event.processId;

var oldValue = this.webviewNode_.getAttribute('src');

var newValue = event.url;

- if (event.isTopLevel && (oldValue != newValue)) {

+ if (event.isTopLevel && !DocumentNatives.CompareURLs(oldValue, newValue)) {

// Touching the src attribute triggers a navigation. To avoid

// triggering a page reload on every guest-initiated navigation,

// we use the flag ignoreNextSrcAttributeChange_ here.