content/browser/web_contents/web_contents_impl.cc - Issue 27408004: <webview>: Resolve relative paths as chrome-extension: URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 27408004: <webview>: Resolve relative paths as chrome-extension: URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactor + addressed creis' comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_plugin/browser_plugin_guest.h ('K') | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/public/browser/browser_plugin_guest_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index f089c4a5ecf548134d453e3f6d814b28969423e5..53097f761db2f8fa48af711b6bb095fe10f3a3d9 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -452,7 +452,7 @@ BrowserPluginGuest* WebContentsImpl::CreateGuest(

// This makes |new_contents| act as a guest.

// For more info, see comment above class BrowserPluginGuest.

BrowserPluginGuest::Create(

- guest_instance_id, new_contents, extra_params.Pass());

+ guest_instance_id, site_instance, new_contents, extra_params.Pass());

Charlie Reis 2013/10/30 20:42:20 Which SiteInstance is this? How does it get the e

WebContents::CreateParams create_params(browser_context, site_instance);

new_contents->Init(create_params);