<webview>: Resolve relative paths as chrome-extension: URLs

chrome/browser/guestview/webview/webview_guest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/guestview/webview/webview_guest.h"
 
 #include "base/command_line.h"
+#include "base/strings/stringprintf.h"
 #include "chrome/browser/extensions/api/web_request/web_request_api.h"
 #include "chrome/browser/extensions/extension_renderer_state.h"
 #include "chrome/browser/extensions/script_executor.h"
 #include "chrome/browser/favicon/favicon_tab_helper.h"
 #include "chrome/browser/guestview/guestview_constants.h"
 #include "chrome/browser/guestview/webview/webview_constants.h"
 #include "chrome/browser/guestview/webview/webview_permission_types.h"
 #include "chrome/common/chrome_version_info.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/resource_request_details.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/result_codes.h"
+#include "extensions/common/constants.h"
 #include "net/base/net_errors.h"
 
 #if defined(ENABLE_PLUGINS)
 #include "chrome/browser/guestview/webview/plugin_permission_helper.h"
 #endif
 
 using content::WebContents;
 
 namespace {
 
@@ skipping 502 matching lines @@
     WebContents* web_contents) {
   content::BrowserThread::PostTask(
       content::BrowserThread::IO, FROM_HERE,
       base::Bind(
           &ExtensionRendererState::RemoveWebView,
           base::Unretained(ExtensionRendererState::GetInstance()),
           web_contents->GetRenderProcessHost()->GetID(),
           web_contents->GetRoutingID()));
 }
 
+GURL WebViewGuest::ResolveURL(const std::string& src) {
+  if (!attached())
+    return GURL(src);
+  const content::SiteInstance* embedder_site_instance =
+      embedder_web_contents()->GetSiteInstance();
+  const GURL& embedder_site_url = embedder_site_instance->GetSiteURL();
+  GURL default_url(base::StringPrintf("%s://%s/",
+                                      extensions::kExtensionScheme,
+                                      embedder_site_url.host().c_str()));

[Charlie Reis, 2013/10/18 17:37:55]

What will this do in Hui's case, when we have a webview embedded in a WebUI
process?

[Fady Samuel, 2013/10/25 21:10:31]

I now base this on the extension_id which is always the correct value.

In the case of window.open, WebViewGuest gets an extension ID from its opener.

In the case of a webview initial navigation, WebViewGuest::Attach is always
called immediately after creation, and so WebViewGuest::ResolveURL will always
have a non-empty extension_id(). I added a DCHECK with this assertion.

[Charlie Reis, 2013/10/29 21:11:39]

Thanks.
Please put a comment like this on the declaration of extension_id_ in GuestView,
so that the lifetime is a bit more clear.

+  return default_url.Resolve(src);
+}
+
 void WebViewGuest::SizeChanged(const gfx::Size& old_size,
                                const gfx::Size& new_size) {
   scoped_ptr<DictionaryValue> args(new DictionaryValue());
   args->SetInteger(webview::kOldHeight, old_size.height());
   args->SetInteger(webview::kOldWidth, old_size.width());
   args->SetInteger(webview::kNewHeight, new_size.height());
   args->SetInteger(webview::kNewWidth, new_size.width());
   DispatchEvent(new GuestView::Event(webview::kEventSizeChanged, args.Pass()));
 }
 
 WebViewGuest::PermissionResponseInfo::PermissionResponseInfo()
     : allowed_by_default(false) {
 }
 
 WebViewGuest::PermissionResponseInfo::PermissionResponseInfo(
     const PermissionResponseCallback& callback,
     bool allowed_by_default)
     : callback(callback),
       allowed_by_default(allowed_by_default) {
 }
 
 WebViewGuest::PermissionResponseInfo::~PermissionResponseInfo() {
 }