chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js - Issue 2740793002: Minimize the Classic API and enable it for Next

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js

Issue 2740793002: Minimize the Classic API and enable it for Next (Closed)

Patch Set: Minimize the Classic API and enable it for Next Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/injected/loader.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js

index fcc3b8c88056b27003e5d10b79a8715bddba9b2e..76904677001e3d46ea65b9d75ddeb003a6661277 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js

@@ -39,7 +39,6 @@ BackgroundKeyboardHandler.prototype = {

return false;

if (ChromeVoxState.instance.mode != ChromeVoxMode.CLASSIC &&

- ChromeVoxState.instance.mode != ChromeVoxMode.NEXT_COMPAT &&

!cvox.ChromeVoxKbHandler.basicKeyDownActionsListener(evt)) {

evt.preventDefault();

evt.stopPropagation();

@@ -81,8 +80,7 @@ BackgroundKeyboardHandler.prototype = {

* @param {ChromeVoxMode?} oldMode

onModeChanged: function(newMode, oldMode) {

- if (newMode == ChromeVoxMode.CLASSIC ||

- newMode == ChromeVoxMode.NEXT_COMPAT) {

+ if (newMode == ChromeVoxMode.CLASSIC) {

chrome.accessibilityPrivate.setKeyboardListener(false, false);

} else {

chrome.accessibilityPrivate.setKeyboardListener(

@@ -90,8 +88,7 @@ BackgroundKeyboardHandler.prototype = {

}

if (newMode === ChromeVoxMode.NEXT ||

- newMode === ChromeVoxMode.FORCE_NEXT ||

- newMode === ChromeVoxMode.NEXT_COMPAT) {

+ newMode === ChromeVoxMode.FORCE_NEXT) {

// Switching out of classic, classic compat, or uninitialized

// (on startup).

window['prefs'].switchToKeyMap('keymap_next');