Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1958)

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js

Issue 2740793002: Minimize the Classic API and enable it for Next (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js
index db0f689bcc438bf4a58d1475e3762394aae99602..739136357eadba5ab67beba9c412556bddce1508 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js
@@ -11,7 +11,6 @@ goog.provide('cvox.ChromeVoxEventWatcher');
goog.provide('cvox.ChromeVoxEventWatcherUtil');
goog.require('cvox.ActiveIndicator');
-goog.require('cvox.ApiImplementation');
goog.require('cvox.AriaUtil');
goog.require('cvox.ChromeVox');
goog.require('cvox.ChromeVoxEditableTextBase');
@@ -593,8 +592,7 @@ cvox.ChromeVoxEventWatcher.mouseOverEventWatcher = function(evt) {
cvox.ChromeVox.navigationManager.stopReading(true);
var target = /** @type {Node} */(evt.target);
cvox.Focuser.setFocus(target);
- cvox.ApiImplementation.syncToNode(
dmazzoni 2017/03/09 00:26:35 Are you sure it's a no-op to remove these? I thou
- target, true, cvox.ChromeVoxEventWatcher.queueMode_());
+
cvox.ChromeVoxEventWatcher.announcedMouseOverNode = target;
});
}, mouseoverDelayMs);
@@ -688,8 +686,6 @@ cvox.ChromeVoxEventWatcher.focusHandler = function(evt) {
// Navigate to this control so that it will be the same for focus as for
// regular navigation.
- cvox.ApiImplementation.syncToNode(
- target, !document.webkitHidden, queueMode);
if ((evt.target.constructor == HTMLVideoElement) ||
(evt.target.constructor == HTMLAudioElement)) {
@@ -1138,9 +1134,7 @@ cvox.ChromeVoxEventWatcher.handleControlChanged = function(control) {
parentControl != control &&
document.activeElement == control)) {
// Sync ChromeVox to the newly selected control.
- cvox.ApiImplementation.syncToNode(
- activeDescendant || control, true,
- cvox.ChromeVoxEventWatcher.queueMode_());
+
announceChange = false;
} else if (activeDescendant) {
cvox.ChromeVox.navigationManager.updateSelToArbitraryNode(
@@ -1435,9 +1429,6 @@ cvox.ChromeVoxEventWatcher.handleEvent_ = function(evt) {
case 'keypress':
cvox.ChromeVoxEventWatcher.setUpTextHandler();
break;
- case 'click':
- cvox.ApiImplementation.syncToNode(/** @type {Node} */(evt.target), true);
- break;
case 'focus':
cvox.ChromeVoxEventWatcher.focusHandler(evt);
break;

Powered by Google App Engine
This is Rietveld 408576698