Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: content/public/test/test_utils.cc

Issue 2740783003: Revert "Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop. (patchset #3 id… (Closed)
Patch Set: Patch for NavigatingExtensionPopupBrowserTest.DownloadViaPost. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/test_utils.cc
diff --git a/content/public/test/test_utils.cc b/content/public/test/test_utils.cc
index 4afe2321e9f3f4c021831dc3857db3582e9991a7..1d2da32abb0acc830b7f43ebff665f4bfb88c092 100644
--- a/content/public/test/test_utils.cc
+++ b/content/public/test/test_utils.cc
@@ -292,8 +292,8 @@ void WindowedNotificationObserver::Wait() {
return;
running_ = true;
- message_loop_runner_ = new MessageLoopRunner;
- message_loop_runner_->Run();
+ run_loop_.reset(new base::RunLoop);
+ run_loop_->Run();
EXPECT_TRUE(seen_);
}
@@ -310,7 +310,7 @@ void WindowedNotificationObserver::Observe(
if (!running_)
return;
- message_loop_runner_->Quit();
+ run_loop_->Quit();
running_ = false;
}

Powered by Google App Engine
This is Rietveld 408576698