Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: extensions/test/extension_test_notification_observer.cc

Issue 2740783003: Revert "Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop. (patchset #3 id… (Closed)
Patch Set: Fix comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/test_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/test/extension_test_notification_observer.cc
diff --git a/extensions/test/extension_test_notification_observer.cc b/extensions/test/extension_test_notification_observer.cc
index 3d2f23fa418d520841d62150be37c533f5bd4465..69c30d70169ddbf9aec66c10726f48475f1ff749 100644
--- a/extensions/test/extension_test_notification_observer.cc
+++ b/extensions/test/extension_test_notification_observer.cc
@@ -194,16 +194,15 @@ void ExtensionTestNotificationObserver::WaitForCondition(
return;
condition_ = condition;
- scoped_refptr<content::MessageLoopRunner> runner(
- new content::MessageLoopRunner);
- quit_closure_ = runner->QuitClosure();
+ base::RunLoop run_loop;
+ quit_closure_ = run_loop.QuitClosure();
std::unique_ptr<base::CallbackList<void()>::Subscription> subscription;
if (notification_set) {
subscription = notification_set->callback_list().Add(base::Bind(
&ExtensionTestNotificationObserver::MaybeQuit, base::Unretained(this)));
}
- runner->Run();
+ run_loop.Run();
condition_.Reset();
quit_closure_.Reset();
« no previous file with comments | « content/public/test/test_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698