chrome/browser/printing/print_preview_dialog_controller_browsertest.cc - Issue 2740783003: Revert "Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop. (patchset #3 id…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

Issue 2740783003: Revert "Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop. (patchset #3 id… (Closed)

Patch Set: Fix comment. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_extension_test_notification_observer.cc ('k') | chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

diff --git a/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc b/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

index 335becff7f9da01598fb382e25f39bb9a385a78b..ecf843aa0b90eecfee3e37ad9bae014bc0feee0c 100644

--- a/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

+++ b/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

@@ -266,6 +266,11 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewDialogControllerBrowserTest,

chrome::Reload(browser(), WindowOpenDisposition::CURRENT_TAB);

content::WaitForLoadStop(

browser()->tab_strip_model()->GetActiveWebContents());

+ // When Widget::Close is called, a task is posted that will destroy the

+ // widget. Here the widget is closed when the navigation commits. Load stop

+ // may occur right after the commit, before the widget is destroyed.

+ // Execute pending tasks to account for this.

+ base::RunLoop().RunUntilIdle();

ASSERT_TRUE(dialog_destroyed_observer.dialog_destroyed());

// Try printing again.