Issue 274078: Always re-layout the app menu to get sync system state....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 274078: Always re-layout the app menu to get sync system state.... (Closed)

Created:
11 years, 2 months ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman, ncarter (slow)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Always re-layout the app menu to get sync system state. BUG=25103 TEST=Start chrome, verify app menu says 'Synchronize my bookmarks...'. Click it, and set up sync. Reopen app menu, and it should say 'Bookmarks synced...' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29339

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/views/toolbar_view.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

We need to land this today for beta, not sure if Aaron is around (pinged ...

11 years, 2 months ago (2009-10-16 20:23:29 UTC) #3

ncarter (slow)

11 years, 2 months ago (2009-10-16 20:27:11 UTC) #4

LGTM based on the principle of "that's how it was yesterday when it worked"

Expand Messages | Collapse Messages