content/renderer/android/email_detector.cc - Issue 2740673002: Prepare Chromium and Blink for ICU 59

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/android/email_detector.cc

Issue 2740673002: Prepare Chromium and Blink for ICU 59 (Closed)

Patch Set: revert accidental revert of sftnly roll during rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/android/email_detector.cc

diff --git a/content/renderer/android/email_detector.cc b/content/renderer/android/email_detector.cc

index 564f3417305fc2c398de64931377835829b62fdb..1a0db8b07a850ec383b75e0be6dc209e16e43fbf 100644

--- a/content/renderer/android/email_detector.cc

+++ b/content/renderer/android/email_detector.cc

@@ -62,8 +62,8 @@ bool EmailDetector::FindContent(const base::string16::const_iterator& begin,

DCHECK(U_SUCCESS(status));

icu::UnicodeString content_ustr(matcher->group(status));

DCHECK(U_SUCCESS(status));

- base::UTF16ToUTF8(content_ustr.getBuffer(), content_ustr.length(),

- content_text);

+ content_text->clear();

+ content_ustr.toUTF8String(*content_text);

return true;

}