Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/i18n/number_formatting.cc

Issue 2740673002: Prepare Chromium and Blink for ICU 59 (Closed)
Patch Set: fix one more file in Blink; blink_tests can be built without any error on Linux Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/i18n/message_formatter.cc ('k') | base/i18n/string_compare.cc » ('j') | base/i18n/unicodestring.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/i18n/number_formatting.cc
diff --git a/base/i18n/number_formatting.cc b/base/i18n/number_formatting.cc
index b5108334846099eb66d8913b905d61d3391b94f0..5a0503f77de186289b91a178adc41e4002a58f6e 100644
--- a/base/i18n/number_formatting.cc
+++ b/base/i18n/number_formatting.cc
@@ -10,6 +10,7 @@
#include "base/format_macros.h"
#include "base/i18n/message_formatter.h"
+#include "base/i18n/unicodestring.h"
#include "base/lazy_instance.h"
#include "base/logging.h"
#include "base/strings/string_util.h"
@@ -60,7 +61,7 @@ string16 FormatNumber(int64_t number) {
icu::UnicodeString ustr;
number_format->format(number, ustr);
- return string16(ustr.getBuffer(), static_cast<size_t>(ustr.length()));
+ return i18n::UnicodeStringToString16(ustr);
}
string16 FormatDouble(double number, int fractional_digits) {
@@ -76,7 +77,7 @@ string16 FormatDouble(double number, int fractional_digits) {
icu::UnicodeString ustr;
number_format->format(number, ustr);
- return string16(ustr.getBuffer(), static_cast<size_t>(ustr.length()));
+ return i18n::UnicodeStringToString16(ustr);
}
string16 FormatPercent(int number) {
« no previous file with comments | « base/i18n/message_formatter.cc ('k') | base/i18n/string_compare.cc » ('j') | base/i18n/unicodestring.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698