Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: base/i18n/string_compare.cc

Issue 2740673002: Prepare Chromium and Blink for ICU 59 (Closed)
Patch Set: revert accidental revert of sftnly roll during rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/i18n/number_formatting.cc ('k') | base/i18n/time_formatting.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/i18n/string_compare.h" 5 #include "base/i18n/string_compare.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "third_party/icu/source/common/unicode/unistr.h"
9 10
10 namespace base { 11 namespace base {
11 namespace i18n { 12 namespace i18n {
12 13
13 // Compares the character data stored in two different string16 strings by 14 // Compares the character data stored in two different string16 strings by
14 // specified Collator instance. 15 // specified Collator instance.
15 UCollationResult CompareString16WithCollator(const icu::Collator& collator, 16 UCollationResult CompareString16WithCollator(const icu::Collator& collator,
16 const string16& lhs, 17 const string16& lhs,
17 const string16& rhs) { 18 const string16& rhs) {
18 UErrorCode error = U_ZERO_ERROR; 19 UErrorCode error = U_ZERO_ERROR;
19 UCollationResult result = collator.compare( 20 UCollationResult result = collator.compare(
20 static_cast<const UChar*>(lhs.c_str()), static_cast<int>(lhs.length()), 21 icu::UnicodeString(FALSE, lhs.c_str(), static_cast<int>(lhs.length())),
21 static_cast<const UChar*>(rhs.c_str()), static_cast<int>(rhs.length()), 22 icu::UnicodeString(FALSE, rhs.c_str(), static_cast<int>(rhs.length())),
22 error); 23 error);
23 DCHECK(U_SUCCESS(error)); 24 DCHECK(U_SUCCESS(error));
24 return result; 25 return result;
25 } 26 }
26 27
27 } // namespace i18n 28 } // namespace i18n
28 } // namespace base 29 } // namespace base
OLDNEW
« no previous file with comments | « base/i18n/number_formatting.cc ('k') | base/i18n/time_formatting.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698