Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3012)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/about_flags.cc

Issue 2740633002: [Autofill] Add upstreaming UKM (Closed)
Patch Set: Addressed comments + feature flag Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/autofill/chrome_autofill_client.h » ('j') | components/autofill/core/browser/autofill_experiments.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index ff4735d76b77be76929353907895ed7fdb93cd9b..2fda109f1795e284e9acd5d35ac61134cc315182 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -2328,6 +2328,10 @@ const FeatureEntry kFeatureEntries[] = {
FEATURE_VALUE_TYPE(chrome::android::kCustomFeedbackUi)},
#endif // OS_ANDROID
+ {"enable-autofill-log-ukm", IDS_FLAGS_ENABLE_AUTOFILL_UKM_NAME,
+ IDS_FLAGS_ENABLE_AUTOFILL_UKM_DESCRIPTION, kOsAll,
+ FEATURE_VALUE_TYPE(autofill::kAutofillUkmLogging)},
+
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/autofill/chrome_autofill_client.h » ('j') | components/autofill/core/browser/autofill_experiments.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698