Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: components/autofill/core/browser/autofill_ukm.cc

Issue 2740633002: [Autofill] Add upstreaming UKM (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_ukm.cc
diff --git a/components/autofill/core/browser/autofill_ukm.cc b/components/autofill/core/browser/autofill_ukm.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c80928670a654d9c18f77674f1ad3bc8098f4688
--- /dev/null
+++ b/components/autofill/core/browser/autofill_ukm.cc
@@ -0,0 +1,52 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/autofill/core/browser/autofill_ukm.h"
+
+#include "components/ukm/ukm_entry_builder.h"
+#include "components/ukm/ukm_service.h"
+#include "url/gurl.h"
+
+namespace autofill {
+
+AutofillUkm::AutofillUkm(ukm::UkmService* ukm_service)
+ : ukm_service_(ukm_service) {}
+
+AutofillUkm::~AutofillUkm() {}
+
+void AutofillUkm::SetCardUploadDecisionMetricUrl(const GURL& url) {
+ if (ShouldLog(url)) {
+ card_upload_decision_url_.reset(new GURL(url));
Mathieu 2017/03/08 22:33:49 I think I would prefer if |card_upload_decision_ur
+ }
+}
+
+void AutofillUkm::LogCardUploadDecisionMetric(
+ AutofillMetrics::CardUploadDecisionMetric upload_decision) {
+ if (card_upload_decision_url_ &&
+ upload_decision < AutofillMetrics::NUM_CARD_UPLOAD_DECISION_METRICS) {
+ DVLOG(3) << "Sending event for url: " << card_upload_decision_url_->spec();
+ int32_t source_id = ukm_service_->GetNewSourceID();
+ ukm_service_->UpdateSourceURL(source_id, *card_upload_decision_url_.get());
+ std::unique_ptr<ukm::UkmEntryBuilder> builder =
+ ukm_service_->GetEntryBuilder(source_id, "Autofill.CardUploadDecision");
+ builder->AddMetric("UploadDecision", upload_decision);
+
+ card_upload_decision_url_.reset();
+ }
+}
+
+bool AutofillUkm::ShouldLog(const GURL& url) {
+ if (!url.is_valid()) {
+ return false;
+ }
+
+ if (!ukm_service_) {
+ DVLOG(3) << "No UKM service.";
+ return false;
+ }
+
+ return true;
+}
+
+} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698