Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Side by Side Diff: components/autofill/core/browser/autofill_experiments.h

Issue 2740633002: [Autofill] Add upstreaming UKM (Closed)
Patch Set: Addressed comments + feature flag Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXPERIMENTS_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXPERIMENTS_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXPERIMENTS_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXPERIMENTS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 10 matching lines...) Expand all
21 } 21 }
22 22
23 namespace autofill { 23 namespace autofill {
24 24
25 struct Suggestion; 25 struct Suggestion;
26 26
27 extern const base::Feature kAutofillCreditCardAssist; 27 extern const base::Feature kAutofillCreditCardAssist;
28 extern const base::Feature kAutofillScanCardholderName; 28 extern const base::Feature kAutofillScanCardholderName;
29 extern const base::Feature kAutofillCreditCardPopupLayout; 29 extern const base::Feature kAutofillCreditCardPopupLayout;
30 extern const base::Feature kAutofillCreditCardLastUsedDateDisplay; 30 extern const base::Feature kAutofillCreditCardLastUsedDateDisplay;
31 extern const base::Feature kAutofillUkmLogging;
31 extern const char kCreditCardSigninPromoImpressionLimitParamKey[]; 32 extern const char kCreditCardSigninPromoImpressionLimitParamKey[];
32 extern const char kAutofillCreditCardPopupSettingsSuggestionValueKey[]; 33 extern const char kAutofillCreditCardPopupSettingsSuggestionValueKey[];
33 extern const char kAutofillCreditCardLastUsedDateShowExpirationDateKey[]; 34 extern const char kAutofillCreditCardLastUsedDateShowExpirationDateKey[];
34 35
35 // Returns true if autofill should be enabled. See also 36 // Returns true if autofill should be enabled. See also
36 // IsInAutofillSuggestionsDisabledExperiment below. 37 // IsInAutofillSuggestionsDisabledExperiment below.
37 bool IsAutofillEnabled(const PrefService* pref_service); 38 bool IsAutofillEnabled(const PrefService* pref_service);
38 39
39 // Returns true if autofill suggestions are disabled via experiment. The 40 // Returns true if autofill suggestions are disabled via experiment. The
40 // disabled experiment isn't the same as disabling autofill completely since we 41 // disabled experiment isn't the same as disabling autofill completely since we
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 94
94 // Modifies the suggestion value and label if the new credit card autofill popup 95 // Modifies the suggestion value and label if the new credit card autofill popup
95 // experiment is enabled to tweak the display of the value and label. 96 // experiment is enabled to tweak the display of the value and label.
96 void ModifyAutofillCreditCardSuggestion(struct Suggestion* suggestion); 97 void ModifyAutofillCreditCardSuggestion(struct Suggestion* suggestion);
97 98
98 // Returns the margin for the icon, label and between icon and label. Returns 0 99 // Returns the margin for the icon, label and between icon and label. Returns 0
99 // if the margin isn't configured in an experiment to tweak autofill popup 100 // if the margin isn't configured in an experiment to tweak autofill popup
100 // layout. 101 // layout.
101 unsigned int GetPopupMargin(); 102 unsigned int GetPopupMargin();
102 103
104 // Returns whether the feature to log UKMs is enabled.
105 bool IsLoggingUkmEnabled();
Mathieu 2017/03/09 20:13:26 *IsUkmLoggingEnabled to be consistent with the nam
sebsg 2017/03/09 20:52:16 Done.
106
103 } // namespace autofill 107 } // namespace autofill
104 108
105 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXPERIMENTS_H_ 109 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXPERIMENTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698