Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2740633002: [Autofill] Add upstreaming UKM (Closed)
Patch Set: Addressed comments + feature flag Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2310 matching lines...) Expand 10 before | Expand all | Expand 10 after
2321 FEATURE_VALUE_TYPE(omnibox::kOmniboxEntitySuggestions)}, 2321 FEATURE_VALUE_TYPE(omnibox::kOmniboxEntitySuggestions)},
2322 #endif // defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) || 2322 #endif // defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) ||
2323 // defined(OS_WIN) 2323 // defined(OS_WIN)
2324 2324
2325 #if defined(OS_ANDROID) 2325 #if defined(OS_ANDROID)
2326 {"enable-custom-feedback-ui", IDS_FLAGS_ENABLE_CUSTOM_FEEDBACK_UI_NAME, 2326 {"enable-custom-feedback-ui", IDS_FLAGS_ENABLE_CUSTOM_FEEDBACK_UI_NAME,
2327 IDS_FLAGS_ENABLE_CUSTOM_FEEDBACK_UI_DESCRIPTION, kOsAndroid, 2327 IDS_FLAGS_ENABLE_CUSTOM_FEEDBACK_UI_DESCRIPTION, kOsAndroid,
2328 FEATURE_VALUE_TYPE(chrome::android::kCustomFeedbackUi)}, 2328 FEATURE_VALUE_TYPE(chrome::android::kCustomFeedbackUi)},
2329 #endif // OS_ANDROID 2329 #endif // OS_ANDROID
2330 2330
2331 {"enable-autofill-log-ukm", IDS_FLAGS_ENABLE_AUTOFILL_UKM_NAME,
2332 IDS_FLAGS_ENABLE_AUTOFILL_UKM_DESCRIPTION, kOsAll,
2333 FEATURE_VALUE_TYPE(autofill::kAutofillUkmLogging)},
2334
2331 // NOTE: Adding new command-line switches requires adding corresponding 2335 // NOTE: Adding new command-line switches requires adding corresponding
2332 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2336 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2333 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2337 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2334 }; 2338 };
2335 2339
2336 class FlagsStateSingleton { 2340 class FlagsStateSingleton {
2337 public: 2341 public:
2338 FlagsStateSingleton() 2342 FlagsStateSingleton()
2339 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2343 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2340 ~FlagsStateSingleton() {} 2344 ~FlagsStateSingleton() {}
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
2529 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2533 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2530 2534
2531 const FeatureEntry* GetFeatureEntries(size_t* count) { 2535 const FeatureEntry* GetFeatureEntries(size_t* count) {
2532 *count = arraysize(kFeatureEntries); 2536 *count = arraysize(kFeatureEntries);
2533 return kFeatureEntries; 2537 return kFeatureEntries;
2534 } 2538 }
2535 2539
2536 } // namespace testing 2540 } // namespace testing
2537 2541
2538 } // namespace about_flags 2542 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698