Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 274063002: Provide default implementation for BookmarkClient::PreferTouchIcon (Closed)

Created:
6 years, 7 months ago by sdefresne
Modified:
6 years, 7 months ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Provide default implementation for BookmarkClient::PreferTouchIcon The reason to provide default implementations for these methods is that so an embedder that wants to use bookmarks and doesn't need/want favicons or omnibox-related methods doesn't even have to think about what to provide as implementations for them. BUG=367707 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269572

Patch Set 1 #

Patch Set 2 : Fix copy-n-paste error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M components/bookmarks/core/browser/bookmark_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/core/browser/bookmark_client.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/bookmarks/core/test/test_bookmark_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/bookmarks/core/test/test_bookmark_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sdefresne
PTAL
6 years, 7 months ago (2014-05-09 08:58:24 UTC) #1
blundell
lgtm
6 years, 7 months ago (2014-05-09 09:13:46 UTC) #2
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 7 months ago (2014-05-09 12:43:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/274063002/1
6 years, 7 months ago (2014-05-09 12:46:11 UTC) #4
sdefresne
The CQ bit was unchecked by sdefresne@chromium.org
6 years, 7 months ago (2014-05-09 14:47:16 UTC) #5
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 7 months ago (2014-05-09 14:48:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/274063002/20001
6 years, 7 months ago (2014-05-09 14:56:33 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 12:07:19 UTC) #8
Message was sent while issue was closed. 
Change committed as 269572

Powered by Google App Engine
This is Rietveld 408576698