third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp - Issue 2740603003: Hide SpellCheckRequest from other classes in editing/spellcheck

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp

Issue 2740603003: Hide SpellCheckRequest from other classes in editing/spellcheck (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp » ('j') | third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/editing/spellcheck/HotModeSpellCheckRequester.h"	5 #include "core/editing/spellcheck/HotModeSpellCheckRequester.h"

6	6

7 #include "core/editing/EditingUtilities.h"	7 #include "core/editing/EditingUtilities.h"

8 #include "core/editing/Editor.h"	8 #include "core/editing/Editor.h"

9 #include "core/editing/VisiblePosition.h"	9 #include "core/editing/VisiblePosition.h"

10 #include "core/editing/commands/CompositeEditCommand.h"	10 #include "core/editing/commands/CompositeEditCommand.h"

(...skipping 82 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
93 if (!rootEditable \|\| !rootEditable->isConnected())	93 if (!rootEditable \|\| !rootEditable->isConnected())

94 return;	94 return;

95	95

96 if (m_processedRootEditables.contains(rootEditable))	96 if (m_processedRootEditables.contains(rootEditable))

97 return;	97 return;

98 m_processedRootEditables.push_back(rootEditable);	98 m_processedRootEditables.push_back(rootEditable);

99	99

100 if (!shouldCheckRootEditableInHotMode(*rootEditable, position))	100 if (!shouldCheckRootEditableInHotMode(*rootEditable, position))

101 return;	101 return;

102	102

103 SpellCheckRequest* request = SpellCheckRequest::create(	103 const EphemeralRange& checkingRange =

104 calculateHotModeCheckingRange(*rootEditable, position));	104 calculateHotModeCheckingRange(*rootEditable, position);

105 m_requester->requestCheckingFor(request);	105 m_requester->requestCheckingFor(checkingRange);

106 }	106 }

107	107

108 } // namespace blink	108 } // namespace blink

OLD	NEW