Fix dangling ddc references in libraries.dart

Fix dangling ddc references in libraries.dart

Our internal tooling is complaining about this when building / checking the ddc sdk.  It appears to use the analyzer's summary builder tool which seems less forgiving about dangling references / missing files.

R=srawlins@google.com

Committed: https://github.com/dart-lang/sdk/commit/f6e964fca90df33d521b39b10927104f01af3327

[vsm, 2017-03-07 18:40:36]

Description was changed from

==========
Fix dangling ddc references in libraries.dart

Our internal tooling is complaining about this.
==========

to

==========
Fix dangling ddc references in libraries.dart

Our internal tooling is complaining about this when building / checking the ddc
sdk.  It appears to use the analyzer's summary builder tool which seems less
forgiving about dangling references / missing files.
==========

[vsm, 2017-03-07 18:40:36]

vsm@google.com changed reviewers:
+ srawlins@google.com

[Jennifer Messerly, 2017-03-07 19:43:52]

jmesserly@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2017-03-07 19:43:52]

interesting. I'm confused about changing the main SDK libraries.dart for DDC
reasons. DDC doesn't use it yet?

I would like to have unforked libraries.dart, but there were a few problems with
it. nativewrappers.dart was definitely one although I think there were others

https://codereview.chromium.org/2740573003/diff/20001/sdk/lib/_internal/sdk_l...
File sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart (right):

https://codereview.chromium.org/2740573003/diff/20001/sdk/lib/_internal/sdk_l...
sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart:129: dart2jsPath:
"html/dart2js/nativewrappers.dart"),
does this have any bad effects for dart2js?

[vsm, 2017-03-07 19:55:22]

On 2017/03/07 19:43:52, Jennifer Messerly wrote:
> interesting. I'm confused about changing the main SDK libraries.dart for DDC
> reasons. DDC doesn't use it yet?
> 
> I would like to have unforked libraries.dart, but there were a few problems
with
> it. nativewrappers.dart was definitely one although I think there were others
> 
>
https://codereview.chromium.org/2740573003/diff/20001/sdk/lib/_internal/sdk_l...
> File sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart (right):
> 
>
https://codereview.chromium.org/2740573003/diff/20001/sdk/lib/_internal/sdk_l...
> sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart:129: dart2jsPath:
> "html/dart2js/nativewrappers.dart"),
> does this have any bad effects for dart2js?

doh!  I patched the wrong one (did this internally first).  fixing.

[vsm, 2017-03-07 20:10:39]

ptal

[srawlins, 2017-03-07 23:14:10]

lgtm

[vsm, 2017-03-07 23:27:57]

Description was changed from

==========
Fix dangling ddc references in libraries.dart

Our internal tooling is complaining about this when building / checking the ddc
sdk.  It appears to use the analyzer's summary builder tool which seems less
forgiving about dangling references / missing files.
==========

to

==========
Fix dangling ddc references in libraries.dart

Our internal tooling is complaining about this when building / checking the ddc
sdk.  It appears to use the analyzer's summary builder tool which seems less
forgiving about dangling references / missing files.

R=srawlins@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f6e964fca90df33d521b39b10927104f01af3327
==========

[vsm, 2017-03-07 23:27:58]

Committed patchset #3 (id:40001) manually as
f6e964fca90df33d521b39b10927104f01af3327 (presubmit successful).