Linux: Stack autocomplete popup window directly on top of the browser's tople...

Linux: Stack autocomplete popup window directly on top of the browser's toplevel window.

BUG=19082
"Linux: Omnibox auto-complete popup is on top of IME candidate window when using SCIM"
TEST=Please refer to the bug report for how to test.

[Daniel Erat, 2009-10-14 18:16:32]

LGTM

http://codereview.chromium.org/274046/diff/1/5
File chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc (right):

http://codereview.chromium.org/274046/diff/1/5#newcode37
Line 37: toplevel_ = gtk_widget_get_toplevel(edit_view->GetNativeView());
Is it safer to do this in StackWindow(), or is it guaranteed that the toplevel
window will already exist when the popup is initialized?  I don't have a good
feeling for the order in which components are created.

[James Su, 2009-10-15 06:46:20]

Code changed according to your suggestion.

James Su

http://codereview.chromium.org/274046/diff/1/5
File chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc (right):

http://codereview.chromium.org/274046/diff/1/5#newcode37
Line 37: toplevel_ = gtk_widget_get_toplevel(edit_view->GetNativeView());
On 2009/10/14 18:16:32, Daniel Erat wrote:
> Is it safer to do this in StackWindow(), or is it guaranteed that the toplevel
> window will already exist when the popup is initialized?  I don't have a good
> feeling for the order in which components are created.

Current code guarantee that the popup view will be initialized just before it's
popped up the first time.
Anyway, I changed the code according to your suggestion, in case the logic may
change later.