net/tools/quic/quic_spdy_client_stream_test.cc - Issue 2740453006: Add QuicStringPiece which is actually StringPiece.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_spdy_client_stream_test.cc

Issue 2740453006: Add QuicStringPiece which is actually StringPiece. (Closed)

Patch Set: fix compile error and rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/quic/quic_spdy_client_stream_test.cc

diff --git a/net/tools/quic/quic_spdy_client_stream_test.cc b/net/tools/quic/quic_spdy_client_stream_test.cc

index 8ac36804af41cf3b2176d6f6c7467cab6ea8ba77..dcebc1a8f065a6b7f5be5316890ec2f0ef7270c0 100644

--- a/net/tools/quic/quic_spdy_client_stream_test.cc

+++ b/net/tools/quic/quic_spdy_client_stream_test.cc

@@ -156,7 +156,7 @@ TEST_F(QuicSpdyClientStreamTest, TestNoBidirectionalStreaming) {

if (FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {

return;

}

- QuicStreamFrame frame(kClientDataStreamId1, false, 3, StringPiece("asd"));

+ QuicStreamFrame frame(kClientDataStreamId1, false, 3, QuicStringPiece("asd"));

EXPECT_FALSE(stream_->write_side_closed());

stream_->OnStreamFrame(frame);