Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: net/quic/platform/impl/quic_text_utils_impl.h

Issue 2740453006: Add QuicStringPiece which is actually StringPiece. (Closed)
Patch Set: fix compile error and rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/platform/impl/quic_string_piece_impl.h ('k') | net/quic/platform/impl/quic_url_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/platform/impl/quic_text_utils_impl.h
diff --git a/net/quic/platform/impl/quic_text_utils_impl.h b/net/quic/platform/impl/quic_text_utils_impl.h
index c797ac6f446043641ce3d33d4167fae424a40f95..1918632811762cb750d820b71a37759da9f2d041 100644
--- a/net/quic/platform/impl/quic_text_utils_impl.h
+++ b/net/quic/platform/impl/quic_text_utils_impl.h
@@ -9,11 +9,11 @@
#include "base/base64.h"
#include "base/strings/string_number_conversions.h"
-#include "base/strings/string_piece.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "net/base/parse_number.h"
+#include "net/quic/platform/api/quic_string_piece.h"
namespace net {
@@ -21,47 +21,46 @@ namespace net {
class QuicTextUtilsImpl {
public:
// Returns true of |data| starts with |prefix|, case sensitively.
- static bool StartsWith(base::StringPiece data, base::StringPiece prefix) {
+ static bool StartsWith(QuicStringPiece data, QuicStringPiece prefix) {
return base::StartsWith(data, prefix, base::CompareCase::SENSITIVE);
}
// Returns true of |data| ends with |suffix|, case insensitively.
- static bool EndsWithIgnoreCase(base::StringPiece data,
- base::StringPiece suffix) {
+ static bool EndsWithIgnoreCase(QuicStringPiece data, QuicStringPiece suffix) {
return base::EndsWith(data, suffix, base::CompareCase::INSENSITIVE_ASCII);
}
// Returns a new std::string in which |data| has been converted to lower case.
- static std::string ToLower(base::StringPiece data) {
+ static std::string ToLower(QuicStringPiece data) {
return base::ToLowerASCII(data);
}
// Remove leading and trailing whitespace from |data|.
- static void RemoveLeadingAndTrailingWhitespace(base::StringPiece* data) {
+ static void RemoveLeadingAndTrailingWhitespace(QuicStringPiece* data) {
*data = base::TrimWhitespaceASCII(*data, base::TRIM_ALL);
}
// Returns true if |in| represents a valid uint64, and stores that value in
// |out|.
- static bool StringToUint64(base::StringPiece in, uint64_t* out) {
+ static bool StringToUint64(QuicStringPiece in, uint64_t* out) {
return base::StringToUint64(in, out);
}
// Returns true if |in| represents a valid int, and stores that value in
// |out|.
- static bool StringToInt(base::StringPiece in, int* out) {
+ static bool StringToInt(QuicStringPiece in, int* out) {
return base::StringToInt(in, out);
}
// Returns true if |in| represents a valid uint32, and stores that value in
// |out|.
- static bool StringToUint32(base::StringPiece in, uint32_t* out) {
+ static bool StringToUint32(QuicStringPiece in, uint32_t* out) {
return ParseUint32(in, out, nullptr);
}
// Returns true if |in| represents a valid size_t, and stores that value in
// |out|.
- static bool StringToSizeT(base::StringPiece in, size_t* out) {
+ static bool StringToSizeT(QuicStringPiece in, size_t* out) {
return base::StringToSizeT(in, out);
}
@@ -73,13 +72,13 @@ class QuicTextUtilsImpl {
// This converts |length| bytes of binary to a 2*|length|-character
// hexadecimal representation.
// Return value: 2*|length| characters of ASCII std::string.
- static std::string HexEncode(base::StringPiece data) {
+ static std::string HexEncode(QuicStringPiece data) {
return base::ToLowerASCII(::base::HexEncode(data.data(), data.size()));
}
// Converts |data| from a hexadecimal ASCII string to a binary string
// that is |data.length()/2| bytes long.
- static std::string HexDecode(base::StringPiece data) {
+ static std::string HexDecode(QuicStringPiece data) {
if (data.empty())
return "";
std::vector<uint8_t> v;
@@ -115,7 +114,7 @@ class QuicTextUtilsImpl {
// printed as '.' in the ASCII output.
// For example, given the input "Hello, QUIC!\01\02\03\04", returns:
// "0x0000: 4865 6c6c 6f2c 2051 5549 4321 0102 0304 Hello,.QUIC!...."
- static std::string HexDump(base::StringPiece binary_input) {
+ static std::string HexDump(QuicStringPiece binary_input) {
int offset = 0;
const int kBytesPerLine = 16; // Max bytes dumped per line
const char* buf = binary_input.data();
@@ -148,14 +147,13 @@ class QuicTextUtilsImpl {
}
// Returns true if |data| contains any uppercase characters.
- static bool ContainsUpperCase(base::StringPiece data) {
+ static bool ContainsUpperCase(QuicStringPiece data) {
return std::any_of(data.begin(), data.end(), base::IsAsciiUpper<char>);
}
// Splits |data| into a vector of pieces delimited by |delim|.
- static std::vector<base::StringPiece> Split(base::StringPiece data,
- char delim) {
- return base::SplitStringPiece(data, base::StringPiece(&delim, 1),
+ static std::vector<QuicStringPiece> Split(QuicStringPiece data, char delim) {
+ return base::SplitStringPiece(data, QuicStringPiece(&delim, 1),
base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
}
};
« no previous file with comments | « net/quic/platform/impl/quic_string_piece_impl.h ('k') | net/quic/platform/impl/quic_url_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698