net/quic/platform/impl/quic_hostname_utils_impl.cc - Issue 2740453006: Add QuicStringPiece which is actually StringPiece.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/platform/impl/quic_hostname_utils_impl.cc

Issue 2740453006: Add QuicStringPiece which is actually StringPiece. (Closed)

Patch Set: fix compile error and rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/platform/impl/quic_hostname_utils_impl.cc

diff --git a/net/quic/platform/impl/quic_hostname_utils_impl.cc b/net/quic/platform/impl/quic_hostname_utils_impl.cc

index 0dc8139034817271b1965574c0320a783ec37e43..040a724ce4f81980076ac50b4534771ad2402341 100644

--- a/net/quic/platform/impl/quic_hostname_utils_impl.cc

+++ b/net/quic/platform/impl/quic_hostname_utils_impl.cc

@@ -8,13 +8,12 @@

#include "url/gurl.h"

#include "url/url_canon.h"

-using base::StringPiece;

using std::string;

namespace net {

// static

-bool QuicHostnameUtilsImpl::IsValidSNI(StringPiece sni) {

+bool QuicHostnameUtilsImpl::IsValidSNI(QuicStringPiece sni) {

// TODO(rtenneti): Support RFC2396 hostname.

// NOTE: Microsoft does NOT enforce this spec, so if we throw away hostnames

// based on the above spec, we may be losing some hostnames that windows