net/quic/platform/api/quic_str_cat_test.cc - Issue 2740453006: Add QuicStringPiece which is actually StringPiece.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/platform/api/quic_str_cat_test.cc

Issue 2740453006: Add QuicStringPiece which is actually StringPiece. (Closed)

Patch Set: fix compile error and rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/platform/api/quic_str_cat_test.cc

diff --git a/net/quic/platform/api/quic_str_cat_test.cc b/net/quic/platform/api/quic_str_cat_test.cc

index 3064346952d1e4635c5a4343c152342df4502343..dc417d8e36767fcc287d6d95ef0a77ae781f4562 100644

--- a/net/quic/platform/api/quic_str_cat_test.cc

+++ b/net/quic/platform/api/quic_str_cat_test.cc

@@ -4,10 +4,9 @@

#include "net/quic/platform/api/quic_str_cat.h"

-#include "base/strings/string_piece.h"

+#include "net/quic/platform/api/quic_string_piece.h"

#include "testing/gtest/include/gtest/gtest.h"

-using base::StringPiece;

using std::string;

namespace net {

@@ -45,7 +44,7 @@ TEST(QuicStrCatTest, Basics) {

string strs[] = {"Hello", "Cruel", "World"};

- StringPiece pieces[] = {"Hello", "Cruel", "World"};

+ QuicStringPiece pieces[] = {"Hello", "Cruel", "World"};

const char* c_strs[] = {"Hello", "Cruel", "World"};