Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: net/quic/core/quic_packet_generator_test.cc

Issue 2740453006: Add QuicStringPiece which is actually StringPiece. (Closed)
Patch Set: fix compile error and rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_packet_generator.cc ('k') | net/quic/core/quic_packets.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_packet_generator_test.cc
diff --git a/net/quic/core/quic_packet_generator_test.cc b/net/quic/core/quic_packet_generator_test.cc
index 45f8890e0d2dc0915146d6a553fc5e5d788fbe63..990888359cf57e9d911b52bc40b908112f3ab15a 100644
--- a/net/quic/core/quic_packet_generator_test.cc
+++ b/net/quic/core/quic_packet_generator_test.cc
@@ -16,6 +16,7 @@
#include "net/quic/core/quic_simple_buffer_allocator.h"
#include "net/quic/core/quic_utils.h"
#include "net/quic/platform/api/quic_socket_address.h"
+#include "net/quic/platform/api/quic_string_piece.h"
#include "net/quic/test_tools/quic_packet_creator_peer.h"
#include "net/quic/test_tools/quic_packet_generator_peer.h"
#include "net/quic/test_tools/quic_test_utils.h"
@@ -23,7 +24,6 @@
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
-using base::StringPiece;
using std::string;
using testing::InSequence;
using testing::Return;
@@ -202,7 +202,7 @@ class QuicPacketGeneratorTest : public ::testing::Test {
return QuicIOVector(&iov_, 1, len);
}
- QuicIOVector MakeIOVectorFromStringPiece(StringPiece s) {
+ QuicIOVector MakeIOVectorFromStringPiece(QuicStringPiece s) {
return MakeIOVector(s, &iov_);
}
@@ -853,7 +853,7 @@ TEST_F(QuicPacketGeneratorTest, ConnectionCloseFrameLargerThanPacketSize) {
QuicConnectionCloseFrame* frame = new QuicConnectionCloseFrame();
frame->error_code = QUIC_PACKET_WRITE_ERROR;
char buf[2000];
- StringPiece error_details(buf, 2000);
+ QuicStringPiece error_details(buf, 2000);
frame->error_details = error_details.as_string();
EXPECT_CALL(delegate_,
OnUnrecoverableError(QUIC_FAILED_TO_SERIALIZE_PACKET,
« no previous file with comments | « net/quic/core/quic_packet_generator.cc ('k') | net/quic/core/quic_packets.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698