Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: net/quic/core/crypto/crypto_framer_test.cc

Issue 2740453006: Add QuicStringPiece which is actually StringPiece. (Closed)
Patch Set: fix compile error and rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/crypto/crypto_framer.cc ('k') | net/quic/core/crypto/crypto_handshake_message.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/crypto_framer_test.cc
diff --git a/net/quic/core/crypto/crypto_framer_test.cc b/net/quic/core/crypto/crypto_framer_test.cc
index 4210b5f6166f9e497159a778a3cffbd53a8ad948..79fef56feb8ec89408f0e3937a43de053c061aa4 100644
--- a/net/quic/core/crypto/crypto_framer_test.cc
+++ b/net/quic/core/crypto/crypto_framer_test.cc
@@ -15,7 +15,6 @@
#include "net/quic/test_tools/crypto_test_utils.h"
#include "net/quic/test_tools/quic_test_utils.h"
-using base::StringPiece;
using std::string;
namespace net {
@@ -267,7 +266,7 @@ TEST(CryptoFramerTest, ProcessInput) {
};
EXPECT_TRUE(
- framer.ProcessInput(StringPiece(AsChars(input), arraysize(input))));
+ framer.ProcessInput(QuicStringPiece(AsChars(input), arraysize(input))));
EXPECT_EQ(0u, framer.InputBytesRemaining());
EXPECT_EQ(0, visitor.error_count_);
ASSERT_EQ(1u, visitor.messages_.size());
@@ -311,7 +310,7 @@ TEST(CryptoFramerTest, ProcessInputWithThreeKeys) {
};
EXPECT_TRUE(
- framer.ProcessInput(StringPiece(AsChars(input), arraysize(input))));
+ framer.ProcessInput(QuicStringPiece(AsChars(input), arraysize(input))));
EXPECT_EQ(0u, framer.InputBytesRemaining());
EXPECT_EQ(0, visitor.error_count_);
ASSERT_EQ(1u, visitor.messages_.size());
@@ -350,7 +349,7 @@ TEST(CryptoFramerTest, ProcessInputIncrementally) {
};
for (size_t i = 0; i < arraysize(input); i++) {
- EXPECT_TRUE(framer.ProcessInput(StringPiece(AsChars(input) + i, 1)));
+ EXPECT_TRUE(framer.ProcessInput(QuicStringPiece(AsChars(input) + i, 1)));
}
EXPECT_EQ(0u, framer.InputBytesRemaining());
ASSERT_EQ(1u, visitor.messages_.size());
@@ -384,7 +383,7 @@ TEST(CryptoFramerTest, ProcessInputTagsOutOfOrder) {
};
EXPECT_FALSE(
- framer.ProcessInput(StringPiece(AsChars(input), arraysize(input))));
+ framer.ProcessInput(QuicStringPiece(AsChars(input), arraysize(input))));
EXPECT_EQ(QUIC_CRYPTO_TAGS_OUT_OF_ORDER, framer.error());
EXPECT_EQ(1, visitor.error_count_);
}
@@ -412,7 +411,7 @@ TEST(CryptoFramerTest, ProcessEndOffsetsOutOfOrder) {
};
EXPECT_FALSE(
- framer.ProcessInput(StringPiece(AsChars(input), arraysize(input))));
+ framer.ProcessInput(QuicStringPiece(AsChars(input), arraysize(input))));
EXPECT_EQ(QUIC_CRYPTO_TAGS_OUT_OF_ORDER, framer.error());
EXPECT_EQ(1, visitor.error_count_);
}
@@ -432,7 +431,7 @@ TEST(CryptoFramerTest, ProcessInputTooManyEntries) {
};
EXPECT_FALSE(
- framer.ProcessInput(StringPiece(AsChars(input), arraysize(input))));
+ framer.ProcessInput(QuicStringPiece(AsChars(input), arraysize(input))));
EXPECT_EQ(QUIC_CRYPTO_TOO_MANY_ENTRIES, framer.error());
EXPECT_EQ(1, visitor.error_count_);
}
@@ -460,7 +459,7 @@ TEST(CryptoFramerTest, ProcessInputZeroLength) {
};
EXPECT_TRUE(
- framer.ProcessInput(StringPiece(AsChars(input), arraysize(input))));
+ framer.ProcessInput(QuicStringPiece(AsChars(input), arraysize(input))));
EXPECT_EQ(0, visitor.error_count_);
}
« no previous file with comments | « net/quic/core/crypto/crypto_framer.cc ('k') | net/quic/core/crypto/crypto_handshake_message.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698