Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: net/quic/core/crypto/common_cert_set.h

Issue 2740453006: Add QuicStringPiece which is actually StringPiece. (Closed)
Patch Set: fix compile error and rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/crypto/channel_id_test.cc ('k') | net/quic/core/crypto/common_cert_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/common_cert_set.h
diff --git a/net/quic/core/crypto/common_cert_set.h b/net/quic/core/crypto/common_cert_set.h
index 08264c7acb6904a9676854affa19bc49fbd7ae36..8030380ada92efb2dd650acecb9cdc96bce7d262 100644
--- a/net/quic/core/crypto/common_cert_set.h
+++ b/net/quic/core/crypto/common_cert_set.h
@@ -8,9 +8,9 @@
#include <cstdint>
#include "base/compiler_specific.h"
-#include "base/strings/string_piece.h"
#include "net/quic/core/crypto/crypto_protocol.h"
#include "net/quic/platform/api/quic_export.h"
+#include "net/quic/platform/api/quic_string_piece.h"
namespace net {
@@ -23,22 +23,22 @@ class QUIC_EXPORT_PRIVATE CommonCertSets {
// GetInstanceQUIC returns the standard QUIC common certificate sets.
static const CommonCertSets* GetInstanceQUIC();
- // GetCommonHashes returns a StringPiece containing the hashes of common sets
- // supported by this object. The 64-bit hashes are concatenated in the
- // StringPiece.
- virtual base::StringPiece GetCommonHashes() const = 0;
+ // GetCommonHashes returns a QuicStringPiece containing the hashes of common
+ // sets supported by this object. The 64-bit hashes are concatenated in the
+ // QuicStringPiece.
+ virtual QuicStringPiece GetCommonHashes() const = 0;
// GetCert returns a specific certificate (at index |index|) in the common
// set identified by |hash|. If no such certificate is known, an empty
- // StringPiece is returned.
- virtual base::StringPiece GetCert(uint64_t hash, uint32_t index) const = 0;
+ // QuicStringPiece is returned.
+ virtual QuicStringPiece GetCert(uint64_t hash, uint32_t index) const = 0;
// MatchCert tries to find |cert| in one of the common certificate sets
// identified by |common_set_hashes|. On success it puts the hash of the
// set in |out_hash|, the index of |cert| in the set in |out_index| and
// returns true. Otherwise it returns false.
- virtual bool MatchCert(base::StringPiece cert,
- base::StringPiece common_set_hashes,
+ virtual bool MatchCert(QuicStringPiece cert,
+ QuicStringPiece common_set_hashes,
uint64_t* out_hash,
uint32_t* out_index) const = 0;
};
« no previous file with comments | « net/quic/core/crypto/channel_id_test.cc ('k') | net/quic/core/crypto/common_cert_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698