net/quic/chromium/crypto/channel_id_chromium.cc - Issue 2740453006: Add QuicStringPiece which is actually StringPiece.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/chromium/crypto/channel_id_chromium.cc

Issue 2740453006: Add QuicStringPiece which is actually StringPiece. (Closed)

Patch Set: fix compile error and rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/chromium/crypto/channel_id_chromium.cc

diff --git a/net/quic/chromium/crypto/channel_id_chromium.cc b/net/quic/chromium/crypto/channel_id_chromium.cc

index f91f466aa8cac1a232afe90278c34a597e12a722..c451d893df0735f3814ae69553b2dca3cf0ada65 100644

--- a/net/quic/chromium/crypto/channel_id_chromium.cc

+++ b/net/quic/chromium/crypto/channel_id_chromium.cc

@@ -23,7 +23,7 @@ ChannelIDKeyChromium::ChannelIDKeyChromium(

ChannelIDKeyChromium::~ChannelIDKeyChromium() {}

-bool ChannelIDKeyChromium::Sign(base::StringPiece signed_data,

+bool ChannelIDKeyChromium::Sign(QuicStringPiece signed_data,

std::string* out_signature) const {

std::unique_ptr<crypto::ECSignatureCreator> sig_creator(

crypto::ECSignatureCreator::Create(ec_private_key_.get()));