Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2336)

Unified Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h

Issue 2740403002: Persist EffectiveConnectionType in UKM on navigation start. (Closed)
Patch Set: fix ordering Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
index 59df31fd097ce603458ba8be43718b22c56e64ad..16dfbbbbc1898279ab08cb303c32a8c0fec1e93c 100644
--- a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
@@ -7,6 +7,11 @@
#include "base/macros.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+#include "net/nqe/network_quality_estimator.h"
+
+namespace content {
+class WebContents;
+}
namespace internal {
@@ -18,6 +23,7 @@ extern const char kUkmLoadEventName[];
extern const char kUkmFirstContentfulPaintName[];
extern const char kUkmFirstMeaningfulPaintName[];
extern const char kUkmForegroundDurationName[];
+extern const char kUkmEffectiveConnectionType[];
} // namespace internal
@@ -28,9 +34,11 @@ class UkmPageLoadMetricsObserver
public:
// Returns a UkmPageLoadMetricsObserver, or nullptr if it is not needed.
static std::unique_ptr<page_load_metrics::PageLoadMetricsObserver>
- CreateIfNeeded();
+ CreateIfNeeded(content::WebContents* web_contents);
- UkmPageLoadMetricsObserver();
+ explicit UkmPageLoadMetricsObserver(
+ net::NetworkQualityEstimator::NetworkQualityProvider*
+ network_quality_provider);
~UkmPageLoadMetricsObserver() override;
// page_load_metrics::PageLoadMetricsObserver implementation:
@@ -65,9 +73,15 @@ class UkmPageLoadMetricsObserver
const page_load_metrics::PageLoadExtraInfo& info,
base::TimeTicks app_background_time);
+ net::NetworkQualityEstimator::NetworkQualityProvider* const
+ network_quality_provider_;
+
// Unique UKM identifier for the page load we are recording metrics for.
const int32_t source_id_;
+ net::EffectiveConnectionType effective_connection_type_ =
+ net::EFFECTIVE_CONNECTION_TYPE_UNKNOWN;
+
DISALLOW_COPY_AND_ASSIGN(UkmPageLoadMetricsObserver);
};
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698