[Sync] Fix EnableDisableSingleClientTest

chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/test/integration/sync_arc_package_helper.h"
 #include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
 #include "chrome/browser/sync/test/integration/sync_test.h"
-#include "chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.h"
-#include "components/arc/arc_util.h"
 
 namespace arc {
 
 namespace {
 
 bool AllProfilesHaveSameArcPackageDetails() {
   return SyncArcPackageHelper::GetInstance()
       ->AllProfilesHaveSamePackageDetails();
 }
 
 }  // namespace
 
 class TwoClientArcPackageSyncTest : public SyncTest {
  public:
-  TwoClientArcPackageSyncTest()
-      : SyncTest(TWO_CLIENT_LEGACY), sync_helper_(nullptr) {
+  TwoClientArcPackageSyncTest() : SyncTest(TWO_CLIENT_LEGACY) {
     DisableVerifier();
   }
 
   ~TwoClientArcPackageSyncTest() override {}
 
-  bool SetupClients() override {
-    if (!SyncTest::SetupClients())
-      return false;
-
-    // Init SyncArcPackageHelper to ensure that the arc services are initialized
-    // for each Profile.
-    sync_helper_ = SyncArcPackageHelper::GetInstance();
-    return sync_helper_ != nullptr;
-  }
-
-  void SetUpOnMainThread() override {
-    // This setting does not affect the profile created by InProcessBrowserTest.
-    // Only sync test profiles are affected.
-    ArcAppListPrefsFactory::SetFactoryForSyncTest();
-  }
-
-  // Sets up command line flags required for Arc sync tests.
-  void SetUpCommandLine(base::CommandLine* cl) override {
-    SetArcAvailableCommandLineForTesting(cl);
-    SyncTest::SetUpCommandLine(cl);
-  }
-
-  void TearDownOnMainThread() override {
-    sync_helper_ = nullptr;
-    SyncTest::TearDownOnMainThread();
-  }
-
-  SyncArcPackageHelper* sync_helper() { return sync_helper_; }
-
  private:
-  SyncArcPackageHelper* sync_helper_;
-
   DISALLOW_COPY_AND_ASSIGN(TwoClientArcPackageSyncTest);
 };
 
 IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest, StartWithNoPackages) {
   ASSERT_TRUE(SetupSync());
 
   ASSERT_TRUE(AllProfilesHaveSameArcPackageDetails());
 }
 
 IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest, StartWithSamePackages) {
   ASSERT_TRUE(SetupClients());
 
   constexpr size_t kNumPackages = 5;
   for (size_t i = 0; i < kNumPackages; ++i) {
-    sync_helper()->InstallPackageWithIndex(GetProfile(0), i);
-    sync_helper()->InstallPackageWithIndex(GetProfile(1), i);
+    sync_arc_helper()->InstallPackageWithIndex(GetProfile(0), i);
+    sync_arc_helper()->InstallPackageWithIndex(GetProfile(1), i);
   }
 
   ASSERT_TRUE(SetupSync());
 
   ASSERT_TRUE(AllProfilesHaveSameArcPackageDetails());
 }
 
 // In this test, packages are installed before sync started. Client1 will have
 // package 0 to 4 installed while client2 has no package installed.
 IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest,
                        OneClientHasPackagesAnotherHasNone) {
   ASSERT_TRUE(SetupClients());
 
   constexpr size_t kNumPackages = 5;
   for (size_t i = 0; i < kNumPackages; ++i) {
-    sync_helper()->InstallPackageWithIndex(GetProfile(0), i);
+    sync_arc_helper()->InstallPackageWithIndex(GetProfile(0), i);
   }
 
   ASSERT_FALSE(AllProfilesHaveSameArcPackageDetails());
 
   ASSERT_TRUE(SetupSync());
   ASSERT_TRUE(AwaitQuiescence());
   ASSERT_TRUE(AllProfilesHaveSameArcPackageDetails());
 }
 
 // In this test, packages are installed before sync started. Client1 will have
 // package 0 to 9 installed and client2 will have package 0 to 4 installed.
 IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest,
                        OneClientHasPackagesAnotherHasSubSet) {
   ASSERT_TRUE(SetupClients());
 
   constexpr size_t kNumPackages = 5;
   for (size_t i = 0; i < kNumPackages; ++i) {
-    sync_helper()->InstallPackageWithIndex(GetProfile(0), i);
-    sync_helper()->InstallPackageWithIndex(GetProfile(1), i);
+    sync_arc_helper()->InstallPackageWithIndex(GetProfile(0), i);
+    sync_arc_helper()->InstallPackageWithIndex(GetProfile(1), i);
   }
 
   for (size_t i = 0; i < kNumPackages; ++i) {
-    sync_helper()->InstallPackageWithIndex(GetProfile(0), i + kNumPackages);
+    sync_arc_helper()->InstallPackageWithIndex(GetProfile(0), i + kNumPackages);
   }
 
   ASSERT_FALSE(AllProfilesHaveSameArcPackageDetails());
 
   ASSERT_TRUE(SetupSync());
   ASSERT_TRUE(AwaitQuiescence());
   EXPECT_TRUE(AllProfilesHaveSameArcPackageDetails());
 }
 
 // In this test, packages are installed before sync started. Client1 will have
 // package 0 to 4 installed and client2 will have package 1 to 5 installed.
 IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest,
                        StartWithDifferentPackages) {
   ASSERT_TRUE(SetupClients());
 
   constexpr size_t kNumPackages = 5;
   constexpr size_t kPackageIdDiff = 1;
   for (size_t i = 0; i < kNumPackages; ++i) {
-    sync_helper()->InstallPackageWithIndex(GetProfile(0), i);
-    sync_helper()->InstallPackageWithIndex(GetProfile(1), i + kPackageIdDiff);
+    sync_arc_helper()->InstallPackageWithIndex(GetProfile(0), i);
+    sync_arc_helper()->InstallPackageWithIndex(GetProfile(1),
+                                               i + kPackageIdDiff);
   }
 
   EXPECT_FALSE(AllProfilesHaveSameArcPackageDetails());
 
   ASSERT_TRUE(SetupSync());
   ASSERT_TRUE(AwaitQuiescence());
   EXPECT_TRUE(AllProfilesHaveSameArcPackageDetails());
 }
 
 // Tests package installaton after sync started.
 IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest, Install) {
   ASSERT_TRUE(SetupSync());
   ASSERT_TRUE(AllProfilesHaveSameArcPackageDetails());
 
-  sync_helper()->InstallPackageWithIndex(GetProfile(0), 0);
+  sync_arc_helper()->InstallPackageWithIndex(GetProfile(0), 0);
   ASSERT_TRUE(AwaitQuiescence());
   EXPECT_TRUE(AllProfilesHaveSameArcPackageDetails());
 }
 
 // In this test, packages are installed after sync started. Client1 installs
 // package 0 to 4 and client2 installs package 3 to 7.
 IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest, InstallDifferent) {
   ASSERT_TRUE(SetupSync());
   ASSERT_TRUE(AllProfilesHaveSameArcPackageDetails());
 
   constexpr size_t kNumPackages = 5;
   constexpr size_t kPackageIdDiff = 3;
   for (size_t i = 0; i < kNumPackages; ++i) {
-    sync_helper()->InstallPackageWithIndex(GetProfile(0), i);
-    sync_helper()->InstallPackageWithIndex(GetProfile(1), i + kPackageIdDiff);
+    sync_arc_helper()->InstallPackageWithIndex(GetProfile(0), i);
+    sync_arc_helper()->InstallPackageWithIndex(GetProfile(1),
+                                               i + kPackageIdDiff);
   }
 
   ASSERT_TRUE(AwaitQuiescence());
   EXPECT_TRUE(AllProfilesHaveSameArcPackageDetails());
 }
 
 // Installs package from one client and uninstalls from another after sync
 // started.
 IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest, Uninstall) {
   ASSERT_TRUE(SetupSync());
   ASSERT_TRUE(AllProfilesHaveSameArcPackageDetails());
 
-  sync_helper()->InstallPackageWithIndex(GetProfile(0), 1);
+  sync_arc_helper()->InstallPackageWithIndex(GetProfile(0), 1);
   ASSERT_TRUE(AwaitQuiescence());
   EXPECT_TRUE(AllProfilesHaveSameArcPackageDetails());
 
-  sync_helper()->UninstallPackageWithIndex(GetProfile(1), 1);
+  sync_arc_helper()->UninstallPackageWithIndex(GetProfile(1), 1);
   EXPECT_FALSE(AllProfilesHaveSameArcPackageDetails());
   ASSERT_TRUE(AwaitQuiescence());
   EXPECT_TRUE(AllProfilesHaveSameArcPackageDetails());
 }
 
 }  // namespace arc