Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Unified Diff: chrome/browser/ui/libgtkui/select_file_dialog_interactive_uitest.cc

Issue 2740333002: Disable flaky BrowserSelectFileDialogTest.ModalTest on Linux (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/libgtkui/select_file_dialog_interactive_uitest.cc
diff --git a/chrome/browser/ui/libgtkui/select_file_dialog_interactive_uitest.cc b/chrome/browser/ui/libgtkui/select_file_dialog_interactive_uitest.cc
index be18ef84d24e751e66e9b551dbcc5837342bba00..669974c2ed056e8f8e266a3237f33cc12173b781 100644
--- a/chrome/browser/ui/libgtkui/select_file_dialog_interactive_uitest.cc
+++ b/chrome/browser/ui/libgtkui/select_file_dialog_interactive_uitest.cc
@@ -68,7 +68,8 @@ class FilePicker : public ui::SelectFileDialog::Listener {
} // namespace libgtkui
// Leaks in GtkFileChooserDialog. http://crbug.com/537468
-#if defined(ADDRESS_SANITIZER)
+// Flaky on Linux. http://crbug.com/700134
+#if defined(ADDRESS_SANITIZER) || defined(OS_LINUX)
#define MAYBE_ModalTest DISABLED_ModalTest
#else
#define MAYBE_ModalTest ModalTest
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698