tools/gn/command_desc.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/command_desc.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/command_desc.cc

diff --git a/tools/gn/command_desc.cc b/tools/gn/command_desc.cc

index 8e4ebd7e7c0bbc73679ebcce40cca7154751c26b..8dbe6de7de932ec9b67c7cf2219cc6acbf6b8293 100644

--- a/tools/gn/command_desc.cc

+++ b/tools/gn/command_desc.cc

@@ -39,7 +39,7 @@ void PrintValue(const base::Value* value, int indentLevel) {

bool bool_value = false;

if (value->GetAsList(&list_value)) {

for (const auto& v : *list_value) {

- PrintValue(v.get(), indentLevel);

+ PrintValue(&v, indentLevel);

}

} else if (value->GetAsString(&string_value)) {

OutputString(indent);

« no previous file with comments | « services/catalog/entry.cc ('k') | tools/gn/commands.cc » ('j') | no next file with comments »