Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: remoting/protocol/http_ice_config_request.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/test/spawned_test_server/local_test_server.cc ('k') | remoting/test/host_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/http_ice_config_request.cc
diff --git a/remoting/protocol/http_ice_config_request.cc b/remoting/protocol/http_ice_config_request.cc
index 7364341169190c08b10fbbf17aebb21d3dd8a41f..89e751d9029d08f3a9007a6f622738a9320a52fa 100644
--- a/remoting/protocol/http_ice_config_request.cc
+++ b/remoting/protocol/http_ice_config_request.cc
@@ -162,13 +162,13 @@ void HttpIceConfigRequest::OnResponse(const UrlRequest::Result& result) {
// Parse iceServers list and store them in |ice_config|.
bool errors_found = false;
for (const auto& server : *ice_servers_list) {
- base::DictionaryValue* server_dict;
- if (!server->GetAsDictionary(&server_dict)) {
+ const base::DictionaryValue* server_dict;
+ if (!server.GetAsDictionary(&server_dict)) {
errors_found = true;
continue;
}
- base::ListValue* urls_list = nullptr;
+ const base::ListValue* urls_list = nullptr;
if (!server_dict->GetList("urls", &urls_list)) {
errors_found = true;
continue;
@@ -182,7 +182,7 @@ void HttpIceConfigRequest::OnResponse(const UrlRequest::Result& result) {
for (const auto& url : *urls_list) {
std::string url_str;
- if (!url->GetAsString(&url_str)) {
+ if (!url.GetAsString(&url_str)) {
errors_found = true;
continue;
}
« no previous file with comments | « net/test/spawned_test_server/local_test_server.cc ('k') | remoting/test/host_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698