Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: components/url_matcher/url_matcher_factory.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/url_matcher/url_matcher_factory.cc
diff --git a/components/url_matcher/url_matcher_factory.cc b/components/url_matcher/url_matcher_factory.cc
index 0a30497d94e9b7249252db9a49d96b77c3746daa..253d022ece1f9e1cb1965a2e2a0c671bf2cdc081 100644
--- a/components/url_matcher/url_matcher_factory.cc
+++ b/components/url_matcher/url_matcher_factory.cc
@@ -250,10 +250,10 @@ std::unique_ptr<URLMatcherPortFilter> URLMatcherFactory::CreateURLMatcherPorts(
for (const auto& entry : *value_list) {
int port = 0;
- base::ListValue* range = NULL;
- if (entry->GetAsInteger(&port)) {
+ const base::ListValue* range = NULL;
+ if (entry.GetAsInteger(&port)) {
ranges.push_back(URLMatcherPortFilter::CreateRange(port));
- } else if (entry->GetAsList(&range)) {
+ } else if (entry.GetAsList(&range)) {
int from = 0, to = 0;
if (range->GetSize() != 2u ||
!range->GetInteger(0, &from) ||
« no previous file with comments | « components/update_client/component_patcher.cc ('k') | content/browser/accessibility/accessibility_tree_formatter_auralinux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698