Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: components/sync_preferences/pref_model_associator.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_preferences/pref_model_associator.cc
diff --git a/components/sync_preferences/pref_model_associator.cc b/components/sync_preferences/pref_model_associator.cc
index bf7a081069c34db39d4ab18483fdf8d1e4b7c0c6..6bb1801dc52a0ce53b1d64d4449b331e133164d8 100644
--- a/components/sync_preferences/pref_model_associator.cc
+++ b/components/sync_preferences/pref_model_associator.cc
@@ -291,7 +291,7 @@ base::Value* PrefModelAssociator::MergeListValues(const base::Value& from_value,
base::ListValue* result = to_list_value.DeepCopy();
for (const auto& value : from_list_value) {
- result->AppendIfNotPresent(value->CreateDeepCopy());
+ result->AppendIfNotPresent(value.CreateDeepCopy());
}
return result;
}
« no previous file with comments | « components/sync/test/fake_server/fake_server_verifier.cc ('k') | components/translate/core/browser/translate_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698