components/bookmarks/browser/bookmark_expanded_state_tracker.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_expanded_state_tracker.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/browser/bookmark_expanded_state_tracker.cc

diff --git a/components/bookmarks/browser/bookmark_expanded_state_tracker.cc b/components/bookmarks/browser/bookmark_expanded_state_tracker.cc

index c08d8335672d117ac125986d5145c0a0e154b9be..dd3070b039c2c2d99d836812e3b0f03d02bb3b97 100644

--- a/components/bookmarks/browser/bookmark_expanded_state_tracker.cc

+++ b/components/bookmarks/browser/bookmark_expanded_state_tracker.cc

@@ -50,7 +50,7 @@ BookmarkExpandedStateTracker::GetExpandedNodes() {

std::string value;

int64_t node_id;

const BookmarkNode* node;

- if ((*i)->GetAsString(&value) && base::StringToInt64(value, &node_id) &&

+ if (i->GetAsString(&value) && base::StringToInt64(value, &node_id) &&

(node = GetBookmarkNodeByID(bookmark_model_, node_id)) != NULL &&

node->is_folder()) {

nodes.insert(node);