Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chromeos/network/network_sms_handler.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_sms_handler.cc
diff --git a/chromeos/network/network_sms_handler.cc b/chromeos/network/network_sms_handler.cc
index f3eb86eb6fb4d8565dcc3e92ceaa6bd089204a23..42eaf41f8c6da60d6d51721aa5422184e4076950 100644
--- a/chromeos/network/network_sms_handler.cc
+++ b/chromeos/network/network_sms_handler.cc
@@ -115,8 +115,8 @@ void NetworkSmsHandler::ModemManagerNetworkSmsDeviceHandler::ListCallback(
delete_queue_.clear();
for (base::ListValue::const_iterator iter = message_list.begin();
iter != message_list.end(); ++iter) {
- base::DictionaryValue* message = NULL;
- if (!(*iter)->GetAsDictionary(&message))
+ const base::DictionaryValue* message = NULL;
+ if (iter->GetAsDictionary(&message))
continue;
MessageReceived(*message);
double index = 0;
@@ -423,7 +423,7 @@ void NetworkSmsHandler::UpdateDevices(const base::ListValue* devices) {
for (base::ListValue::const_iterator iter = devices->begin();
iter != devices->end(); ++iter) {
std::string device_path;
- (*iter)->GetAsString(&device_path);
+ iter->GetAsString(&device_path);
if (!device_path.empty()) {
// Request device properties.
VLOG(1) << "GetDeviceProperties: " << device_path;
« no previous file with comments | « chromeos/network/managed_network_configuration_handler_impl.cc ('k') | chromeos/network/network_state_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698