Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5538)

Unified Diff: chromeos/dbus/fake_shill_manager_client.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/linux/synchronized_minidump_manager.cc ('k') | chromeos/dbus/shill_client_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/fake_shill_manager_client.cc
diff --git a/chromeos/dbus/fake_shill_manager_client.cc b/chromeos/dbus/fake_shill_manager_client.cc
index 0c103e7161ea21d589e26fb27b9b7c5ddd745bf4..9a1029b8906468bd77472f4013d21b81707d62d8 100644
--- a/chromeos/dbus/fake_shill_manager_client.cc
+++ b/chromeos/dbus/fake_shill_manager_client.cc
@@ -67,7 +67,7 @@ void AppendServicesForType(
for (base::ListValue::const_iterator iter = service_list_in->begin();
iter != service_list_in->end(); ++iter) {
std::string service_path;
- if (!(*iter)->GetAsString(&service_path))
+ if (!iter->GetAsString(&service_path))
continue;
const base::DictionaryValue* properties =
service_client->GetServiceProperties(service_path);
@@ -1027,7 +1027,7 @@ base::ListValue* FakeShillManagerClient::GetEnabledServiceList(
for (base::ListValue::const_iterator iter = service_list->begin();
iter != service_list->end(); ++iter) {
std::string service_path;
- if (!(*iter)->GetAsString(&service_path))
+ if (!iter->GetAsString(&service_path))
continue;
const base::DictionaryValue* properties =
service_client->GetServiceProperties(service_path);
@@ -1038,7 +1038,7 @@ base::ListValue* FakeShillManagerClient::GetEnabledServiceList(
std::string type;
properties->GetString(shill::kTypeProperty, &type);
if (TechnologyEnabled(type))
- new_service_list->Append((*iter)->CreateDeepCopy());
+ new_service_list->Append(iter->CreateDeepCopy());
}
}
return new_service_list;
« no previous file with comments | « chromecast/crash/linux/synchronized_minidump_manager.cc ('k') | chromeos/dbus/shill_client_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698