Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7070)

Unified Diff: chrome/common/extensions/manifest_handlers/linked_app_icons.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_handlers/linked_app_icons.cc
diff --git a/chrome/common/extensions/manifest_handlers/linked_app_icons.cc b/chrome/common/extensions/manifest_handlers/linked_app_icons.cc
index 744a2d16db352bb51b40d8c669adeedb15cece79..d8e2fac5fe1991ab210749e102474d6aea8d044d 100644
--- a/chrome/common/extensions/manifest_handlers/linked_app_icons.cc
+++ b/chrome/common/extensions/manifest_handlers/linked_app_icons.cc
@@ -70,7 +70,7 @@ bool LinkedAppIconsHandler::Parse(Extension* extension, base::string16* error) {
for (const auto& icon_value : *icons_list) {
const base::DictionaryValue* icon_dict = nullptr;
- if (!icon_value->GetAsDictionary(&icon_dict)) {
+ if (!icon_value.GetAsDictionary(&icon_dict)) {
*error = base::UTF8ToUTF16(
extensions::manifest_errors::kInvalidLinkedAppIcon);
return false;

Powered by Google App Engine
This is Rietveld 408576698