chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/action_info.cc ('k') | chrome/common/extensions/api/url_handlers/url_handlers_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

diff --git a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

index 44a4ff1995a84cdde3740fa6a77a146a7a87cb3d..b07e89cdb5dc141bd4a83092d31eaa21850a6a5e 100644

--- a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

+++ b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

@@ -254,8 +254,8 @@ bool LoadFileBrowserHandlers(

FileBrowserHandler::List* result,

base::string16* error) {

for (const auto& entry : *extension_actions) {

- base::DictionaryValue* dict;

- if (!entry->GetAsDictionary(&dict)) {

+ const base::DictionaryValue* dict;

+ if (!entry.GetAsDictionary(&dict)) {

*error = base::ASCIIToUTF16(errors::kInvalidFileBrowserHandler);

return false;

}