chrome/common/extensions/api/common_extension_api_unittest.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/common_extension_api_unittest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/api/common_extension_api_unittest.cc

diff --git a/chrome/common/extensions/api/common_extension_api_unittest.cc b/chrome/common/extensions/api/common_extension_api_unittest.cc

index 776db1c975835699336b98cbfd60084af026720d..3d6e2c6d1a079af459b8c7f1ddd380d6d31ec032 100644

--- a/chrome/common/extensions/api/common_extension_api_unittest.cc

+++ b/chrome/common/extensions/api/common_extension_api_unittest.cc

@@ -802,7 +802,7 @@ TEST(ExtensionAPITest, TypesHaveNamespace) {

const base::DictionaryValue* ret = nullptr;

for (const auto& val : *list) {

const base::DictionaryValue* dict = nullptr;

- if (!val->GetAsDictionary(&dict))

+ if (!val.GetAsDictionary(&dict))

continue;

std::string str;

if (dict->GetString(key, &str) && str == value) {