Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1788)

Unified Diff: chrome/browser/ui/webui/chromeos/login/l10n_util.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/l10n_util.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/l10n_util.cc b/chrome/browser/ui/webui/chromeos/login/l10n_util.cc
index dbc4ab355df974e0bd66987f3d117b773d8ecdad..c4157b3001c05e87e2a99ffce6838ae3c7bf647e 100644
--- a/chrome/browser/ui/webui/chromeos/login/l10n_util.cc
+++ b/chrome/browser/ui/webui/chromeos/login/l10n_util.cc
@@ -477,9 +477,9 @@ std::string FindMostRelevantLocale(
for (base::ListValue::const_iterator available_it =
available_locales.begin();
available_it != available_locales.end(); ++available_it) {
- base::DictionaryValue* dict;
+ const base::DictionaryValue* dict;
std::string available_locale;
- if (!(*available_it)->GetAsDictionary(&dict) ||
+ if (!available_it->GetAsDictionary(&dict) ||
!dict->GetString("value", &available_locale)) {
NOTREACHED();
continue;

Powered by Google App Engine
This is Rietveld 408576698