chrome/browser/spellchecker/spellcheck_service_browsertest.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_service_browsertest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/spellchecker/spellcheck_service_browsertest.cc

diff --git a/chrome/browser/spellchecker/spellcheck_service_browsertest.cc b/chrome/browser/spellchecker/spellcheck_service_browsertest.cc

index ca047baed3e606cb67cb6387f320f2352fecc506..0c3895af3d36afab27f459c2a2452f5a6afe1048 100644

--- a/chrome/browser/spellchecker/spellcheck_service_browsertest.cc

+++ b/chrome/browser/spellchecker/spellcheck_service_browsertest.cc

@@ -133,7 +133,7 @@ class SpellcheckServiceBrowserTest : public InProcessBrowserTest {

std::vector<base::StringPiece> dictionaries;

for (const auto& item_value : *list_value) {

base::StringPiece dictionary;

- EXPECT_TRUE(item_value->GetAsString(&dictionary));

+ EXPECT_TRUE(item_value.GetAsString(&dictionary));

dictionaries.push_back(dictionary);

}

return base::JoinString(dictionaries, ",");