chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/identity_apitest.cc ('k') | chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc

diff --git a/chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc b/chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc

index e54984f45d9bdd288e1c4d3ba4d942a3a29c5dab..b5106121b375fef4c1c6f54fc1902325e9568c7b 100644

--- a/chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc

+++ b/chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc

@@ -112,7 +112,7 @@ bool NativeMessagingHostManifest::Parse(base::DictionaryValue* dictionary,

for (base::ListValue::const_iterator it = allowed_origins_list->begin();

it != allowed_origins_list->end(); ++it) {

std::string pattern_string;

- if (!(*it)->GetAsString(&pattern_string)) {

+ if (!it->GetAsString(&pattern_string)) {

*error_message = "allowed_origins must be list of strings.";

return false;

}